commit | d156657aa88f4e64ef0f898705e9be2665231e23 | [log] [tgz] |
---|---|---|
author | Wes Okuhara <wesokuhara@google.com> | Tue Sep 12 21:42:19 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 12 21:42:19 2023 |
tree | 77edc7d0324ef2cf9820663275d25f98f1e794a7 | |
parent | 78676db87388563a7ab8c277abfd735382c8011f [diff] |
CrOS Settings: Fix deep linking to idle behavior power settings When OsSettingsRevampWayfinding is enabled, the deep link element that for the kPowerIdleBehaviorWhileCharging setting was not focused. This is because there are two elements (one visible, one hidden) configured for this setting and the hidden element was taking focus. Update the page to only have one element stamped with this deep link config at a time. Additionally backfill tests for deep linking to the idle behavior power settings. OsSettingsRevampWayfinding enabled: http://screen/AXaXthg5BxFSHpZ.png OsSettingsRevampWayfinding disabled: http://screen/BkaCKoy37uFEgqu.png Bug: b/298102886 Test: browser_tests --gtest_filter="OSSettingsDevicePage*" Change-Id: Ie1f3d7a6246c72c82958d394d811eeb9bd0602f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4850410 Reviewed-by: Connie Xu <conniekxu@chromium.org> Commit-Queue: Wes Okuhara <wesokuhara@google.com> Cr-Commit-Position: refs/heads/main@{#1195641}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.