| commit | d19707882cd45004992b63dec3bd29bd92384006 | [log] [tgz] |
|---|---|---|
| author | Robbie Gibson <rkgibson@google.com> | Tue Apr 01 20:18:34 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 01 20:18:34 2025 |
| tree | 4c1e17c2afa246380bf7c924d9352b7949c4c1cf | |
| parent | dc25f82b6ac7687f22140ff8d98bd924df0cd774 [diff] |
[iOS] Handle banner promo impression count when UI state changes Before, when `UICurrentlySupportsPromo` was turned on, even if the display count was above the limit, the promo session would not end. Thus a few clients were reporting metrics like the promo appearing 20 times. This check was initially meant to allow a suppressed promo to reappear despite the limit, but as this also counts as an impression, it should obey the limit. Change-Id: Ic36b7894e2661fce759589e85f78a01eeb67bf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6420189 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Cheick Cisse <cheickcisse@google.com> Feels: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/main@{#1441141}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.