commit d1b49ff4d15bc538c4feddff9f81253bba6abd9d
author Sergey Poromov <poromov@chromium.org> Wed Mar 01 10:25:38 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Mar 01 10:25:38 2023
tree e553d5ce399c0f0dd7bf5d9f6aa8206e27afb36e
parent 7d883a31465f8caef4436dc5a82aae33b901a040

Revert "Reland "Consolidate iframe & object resource timing code paths""

This reverts commit c8d82e52681f338bc4671df333a2bc9d6c93a32c.

Reason for revert: Unblocking revert at https://crrev.com/c/4295184

Original change's description:
> Reland "Consolidate iframe & object resource timing code paths"
>
> This is a reland of commit 5dcb6f7b01d5f51144a9ba847c34bb0cdc344ccb
>
> (Reland change: initializing
> WebNavigationTimings::parent_resource_timing_access, caught by MSAN)
> Original change's description:
> > Consolidate iframe & object resource timing code paths
> >
> > So far some of the logic  in resource timing for subframe navigations
> > iframe/object/embed) was duplicated, e.g. both in blink and in content.
> >
> > This has led to race conditions, inconsistencies and sometimes
> > XSS leaks.
> >
> > This patch attempts to improve the situation by consolidating the code
> > paths:
> >
> > - NavigationRequest receives is_container_initiated, which ensures only
> >   container-initiated navigations are reported to the parent. This
> >   is a clarification of something that was ambiguous in the spec
> >   previously (https://github.com/whatwg/html/issues/8846).
> >   It later uses ParentResourceTimingAccess to decide if a navigation
> >   should report to its parent with/without response details
> >   (status code and mime-type), or not report at all (TAO-fail, not
> >   an iframe, not container-initiated).
> >
> > - Both object fallbacks and cancelled navigations (204/205) report
> >   to the parent via RenderFrameImpl, and blink converts that to a
> >   ResourceTimingInfo object. This allows us to remove the duplicated
> >   resource timing creation code in //content.
> >
> > - We report fallback resource timing also for plugin error events and
> >   not only for load events.
> >
> > Bug: 1399862
> > Bug: 1410705
> > Change-Id: Id37d23cd02eee9e38f812e6f3da99caedafdee3d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4214695
> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1110433}
>
> Bug: 1399862
> Bug: 1410705
> Change-Id: Ica01bcc861ffd60909e9adad79ef2f71ab23f98e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296794
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1110858}

Bug: 1399862
Bug: 1410705
Change-Id: I35e3a03d38be4d2cc42d18ee0ed0296b978da090
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299069
Auto-Submit: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Owners-Override: Sergey Poromov <poromov@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1111499}