[Editing] Fix text selection in focusable non-editable elements Previously, SelectionHasFocus() would incorrectly return false when text was selected within focusable but non-editable elements (e.g., elements with tabindex="-1"). This occurred because the existing logic only checked for ancestor/descendant relationships between the selection and focused element, missing cases where they are siblings. This change adds a new condition to SelectionHasFocus() that considers the selection as focused when: 1. The focused element is explicitly focusable but not editable 2. The selection's visible position matches the focused element's position This ensures that text selections in elements like <span tabindex="-1"> are properly displayed as focused, while maintaining existing behavior for contenteditable elements and other focus scenarios. Bug: 40664519 Change-Id: Ic858675ac74dd75edc8da13c77e3fb378001ca86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6721185 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com> Commit-Queue: Tanu Jain <tanujain@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1489369}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.