Google Git
Sign in
chromium / chromium / src / d1d4e7ac500122023681711e419adde3c5588df2
commitd1d4e7ac500122023681711e419adde3c5588df2[log] [tgz]
authorMin Qin <qinmin@chromium.org>Mon May 23 19:25:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 23 19:25:50 2022
tree70fc0b48f9582b3070a57f67ff6ca4bc8f93b0b5
parent3d8460669eab6b4f1c7eb7b6145b2e0cc4dba30a [diff]
[Merge-m103][Segmentation Platform] Fix an issue UKM allowed time pref is updated on
startup

On startup, checking UKM allowed state before profile init will always
return false. This causes the pref timestamp to be set to Time::Max().
Later on, observer will report a UkmAllowedStateChange, and that will
reset the pref value to current time. This causes the platform to think
that UKM is just enabled, and will not report structured metrics.
This CL fixes the issue by not checking the initial value. Since
UkmAllowedStateChange will be called if UKM is allowed, we can just wait
for that call to update the pref. If the pref is not initialized,
segmentation will not record any structured metrics.

BUG=1327768


(cherry picked from commit 0b78c78368e440adacaa9f27e7b16845e60bd160)

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653303
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1006078}
Change-Id: Iac39e8753e8dc91ea5ae0612199cf4764ca1d6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661170
Cr-Commit-Position: refs/branch-heads/5060@{#191}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
9 files changed
tree: 70fc0b48f9582b3070a57f67ff6ca4bc8f93b0b5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.