Google Git
Sign in
chromium / chromium / src / d22357202de90cf3ff847223cdc90eef0f49161f
commitd22357202de90cf3ff847223cdc90eef0f49161f[log] [tgz]
authorSylvain Defresne <sdefresne@chromium.org>Mon Sep 16 13:49:36 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 16 13:49:36 2024
tree59e1b35764914114ef49a5429505d85846d2cb1e
parentca48fa4901bd3b40f2110a45ae6de3fc5df71e90 [diff]
[ios] Improve SessionRestorationServiceImpl

Before this CL, if an unrealized WebState was detached from a Browser,
and the session saved before it could be inserted into another Browser
then the code would crash as it would be unable to find the original
Browser that contained the data.

Change SessionRestorationServiceImpl to keep the OrphanInfo for those
detached WebStates until they are either closed, or inserted into a
Browser.

There was no way to exercise this crash before as the production code
would always move a WebState between Browser without returning to the
main loop, but it was theoretically possible. The hole is now fixed.

Add unit tests that this fixes the crash during both the session save
and the LoadWebStateStorage(...) method.

Bug: none
Change-Id: Iaa9ec3709d2e69d92e35b429224cc0614ea75688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5860161
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1355821}
3 files changed
tree: 59e1b35764914114ef49a5429505d85846d2cb1e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.