[omnibox][actions] Fix action chip focus ring getting cut off. Due to the set of UI updates introduced in http://crrev/c/4923170, it looks like the focus ring is now getting cut off due to improper insets. This CL updates the left margin of the very first action button in the row and adjusts the right margin of the match cell view to accommodate this change. As a result, the non-focused state will remain unchanged, but the focused state will now render the proper action chip UI (i.e. it will no longer appear cut off). NOTE: All below screenshots were taken with the #actions-ui-simplification feature flag enabled. non-focused =========== BEFORE: http://screen/6BRYdZQNxoKKtGi AFTER: http://screen/6Gj2jooRnYg2bhn BEFORE: http://screen/8bJfHpmfZjzHTDw AFTER: http://screen/4FBE7dbhSvZdYxy focused ======= BEFORE: http://screen/8Bd87mi2H4LqVoq AFTER: http://screen/3Ls3WKvxguaFqka BEFORE: http://screen/9StoroAaEvMt5kV AFTER: http://screen/5cj6vnHUCX9Twju BEFORE: http://screen/3cPxiqgm4MbuXdw AFTER: http://screen/7gt9Yth8yH3HcmH Bug: 1479721 Change-Id: Ib4c758aa7ed8662cf2d0246cedf62f41d51ac167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4936855 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Khalid Peer <khalidpeer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1209030}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.