[omnibox][actions] Fix action chip focus ring getting cut off.

Due to the set of UI updates introduced in http://crrev/c/4923170, it
looks like the focus ring is now getting cut off due to improper insets.

This CL updates the left margin of the very first action button in the
row and adjusts the right margin of the match cell view to accommodate
this change.

As a result, the non-focused state will remain unchanged, but the
focused state will now render the proper action chip UI (i.e. it will
no longer appear cut off).

NOTE: All below screenshots were taken with the
#actions-ui-simplification feature flag enabled.

non-focused
===========
BEFORE: http://screen/6BRYdZQNxoKKtGi
AFTER:  http://screen/6Gj2jooRnYg2bhn

BEFORE: http://screen/8bJfHpmfZjzHTDw
AFTER:  http://screen/4FBE7dbhSvZdYxy

focused
=======
BEFORE: http://screen/8Bd87mi2H4LqVoq
AFTER:  http://screen/3Ls3WKvxguaFqka

BEFORE: http://screen/9StoroAaEvMt5kV
AFTER:  http://screen/5cj6vnHUCX9Twju

BEFORE: http://screen/3cPxiqgm4MbuXdw
AFTER:  http://screen/7gt9Yth8yH3HcmH

Bug: 1479721
Change-Id: Ib4c758aa7ed8662cf2d0246cedf62f41d51ac167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4936855
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1209030}
2 files changed
tree: b6ce46c32aece9d1b6ed8387b97994dc88befb50
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.