Google Git
Sign in
chromium / chromium / src / d2575693b8a93aaeb852c03083967b75ecd2f219
commitd2575693b8a93aaeb852c03083967b75ecd2f219[log] [tgz]
authorIvana Žužić <izuzic@google.com>Tue Apr 09 13:46:09 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 09 13:46:09 2024
tree20fff391ece9709f5e44f8dddb86ea69da3e7494
parent40cb9834f809a389ebf57bb34dbbaf3c2157f28f [diff]
[Tab Group Parity][Gardener] Close soft keyboard to accept empty title

The CL was https://crrev.com/c/5419812, caused this test to be flaky:
TabSwitcherLayoutTest#testTabGroupCreation_acceptNullTitle

Explanation of the fix:
The CL enabled autofocusing on the text input field as soon as the
dialog to input the tab group name shows up and it was showing soft
keyboard. That made the test flaky because sometimes the keyboard was
late enough so it was possible to click on the positive button on the
dialog and sometimes the keyboard was shown before Espresso click so
Espresso could not find the positive button, even though it was on the
screen. As explained here:
https://yaqs.corp.google.com/eng/q/8966007151117991936, the soft
keyboard needs to be dismissed before clicking.

Bug: b/333521103, b/41490324
Change-Id: I1f7bc0aae067f9c6eef7abbefa7e84b140d24c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5439274
Owners-Override: Ivana Žužić <izuzic@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Ivana Žužić <izuzic@google.com>
Cr-Commit-Position: refs/heads/main@{#1284441}
1 file changed
tree: 20fff391ece9709f5e44f8dddb86ea69da3e7494
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.