Google Git
Sign in
chromium / chromium / src / d2a5f8df74f00436497521a1473dc5e6d3c8cb2d
commitd2a5f8df74f00436497521a1473dc5e6d3c8cb2d[log] [tgz]
authorKevin McNee <mcnee@chromium.org>Thu Jan 25 01:10:51 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 25 01:10:51 2024
tree3930cd92e002d7866c39b2703df66a38d1c45e39
parentec8eecd43e984630a8a15195a2dd58c987462f80 [diff]
Reduce memory usage of NavigationPredictor AnchorElementData

NavigationPredictor stores a map of information about anchor elements
which can grow quite large, especially for long lived pages with many
anchors.

The following fields are not used and are now removed:
ratio_visible_area, ratio_distance_center_to_visible_top,
ratio_distance_root_bottom.

We change AnchorElementData to no longer store the
blink::mojom::AnchorElementMetrics sent by the renderer, but have fields
to only store the required information. Fields that do not need to be
stored are omitted. Some fields can use a smaller type to store the
necessary information (e.g. the font size is bucketed, and only needs 1
byte to represent possible values). bools are packed together with bit
fields. Fields are arranged to reduce the padding needed for alignment.

Using base::trace_event::EstimateMemoryUsage, the memory usage for the
youtube home page was 56,480 bytes. With this change, it's reduced to
44,960 bytes.

Bug: 1506262, 1419556
Change-Id: Ie430df1626b44ef80af6715f35d91b5f807f24d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234754
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Simon Pelchat <spelchat@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251839}
5 files changed
tree: 3930cd92e002d7866c39b2703df66a38d1c45e39
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.