Google Git
Sign in
chromium / chromium / src / d2db0502b3e07879a38915c56e3bead39ed247e0
commitd2db0502b3e07879a38915c56e3bead39ed247e0[log] [tgz]
authorThuong Phan <thuongphan@chromium.org>Wed Feb 08 22:59:50 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 08 22:59:50 2023
tree201e24be25d1fcb751fd858cfed2ab00f2ba9abe
parent33e073491a43df3f53d5ec435c3aa3dcf29e2b61 [diff]
personalization: refactor ambient_subpage and update toggle_row

- Use top level dom-ifs for different states (personalization-jelly,
showing main-settings or albums subpage, loading) to replace smaller
dom-ifs in the html.
- Update css to fix loading state.
Before: https://screenshot.googleplex.com/yziiwasSx4imX3F
After: https://screenshot.googleplex.com/5pfJJMeyH9sKpG5
- Update toggle-row element to include toggle row title (ON/OFF) as
required in MNext specs.
https://screenshot.googleplex.com/5LgsNm4Uamnorm5
https://screenshot.googleplex.com/6EUZBWTcWV4Y9oR

BUG=b:268065393
TEST=browser_tests --gtest_filter="*AmbientSubpage*"

Change-Id: Ie51ade9beda7e1ae0a3ae710c20a5420a3afc2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4226831
Reviewed-by: Jerry Liu <pzliu@google.com>
Commit-Queue: Thuong Phan <thuongphan@chromium.org>
Reviewed-by: Jeffrey Young <cowmoo@google.com>
Cr-Commit-Position: refs/heads/main@{#1102979}
6 files changed
tree: 201e24be25d1fcb751fd858cfed2ab00f2ba9abe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.