commit d2ed55fb4976616f764830105fb1fdaeb2adbccc
author Colin Blundell <blundell@chromium.org> Thu Apr 21 08:21:35 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 21 08:21:35 2022
tree 92e75c0876b6b183fd48b8450a93abf945e40064
parent 1425e6a817073c00dc48561b99a4e14a1fde7bdf

[CupsPrintJobManagerImpl] Convert away from listening to notification

CupsPrintJobManagerImpl is the last listener of
NOTIFICATION_PRINT_JOB_EVENT. It listens for this notification from all
sources, meaning that it cannot be converted to be a
PrintJob::Observer. This CL instead (a) adds the ability to observe
DocDone events via the global PrintJobManager instance (which already
gets events from all PrintJobs) and (b) changes CupsPrintJobManagerImpl
to listen for these events via PrintJobManager.

Note: One subtlety is that PrintJobManager stops listening for these
events at its shutdown, whereas CupsPrintJobManagerImpl listens for
events all the way to its destruction. Fortunately,
CupsPrintJobManagerImpl is destroyed before PrintJobManager is shut
down:

- CupsPrintJobManagerImpl is a KeyedService, meaning it is destroyed
in profile destruction.
- PrintJobManager::Shutdown() is called by BrowserProcessImpl::Unpin().
- //docs/shutdown.md indicates that Profiles are destroyed before
  BrowserProcessImpl::Unpin() is called.

Bug: 796051
Change-Id: I7f7527456e83f506da32e9524b3edd9f1215c9a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3585362
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994565}