Google Git
Sign in
chromium / chromium / src / d3bdc385be8deb39ff9ebfcc31fe2eeaa65c2f7f
commitd3bdc385be8deb39ff9ebfcc31fe2eeaa65c2f7f[log] [tgz]
authorOrin Jaworski <orinj@google.com>Tue Mar 11 16:37:32 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 11 16:37:32 2025
tree9a6a1258fbb74badbbf3e5bb7c30eb611f92e016
parentf9c398ad0619a23fa8bca7ab39074e9795eb5535 [diff]
Detect starter pack keyword mode entry and open lens overlay for '@page'

This CL creates some event handling structure around the omnibox
controllers and clients so that '@page' keyword mode entry can be
detected and lens overlay machinery can be invoked, e.g. to select
part of the page as context. The OmniboxAction::Client is used
as the main hook to OpenLensOverlay because there's a decent chance
we may want to invoke the flow via an OmniboxAction in the future.

For now this just invokes the context menu command, and the UX is
probably heavier than we want for the omnibox. A TODO is left for
setting up the lighter weight UX where the lens overlay is prepared
in the background while the omnibox can continue receiving keystrokes.

Bug: 401583049
Change-Id: I7d78a9e576537cc6ce16cb2205649cf24fe0d4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6338589
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Nihar Majmudar <niharm@google.com>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1430930}
8 files changed
tree: 9a6a1258fbb74badbbf3e5bb7c30eb611f92e016
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.