commit d3d65a10bae447f128bdcebc1fc4b0a2e4ca103c
author Alan Cutter <alancutter@chromium.org> Tue Sep 15 04:11:11 2020
committer Commit Bot <commit-bot@chromium.org> Tue Sep 15 04:11:11 2020
tree c85ea9d0bb3e4cec8bf300037b476eae80be613b
parent d2e613236c0734b16edc0d18e88085b32d2e47cf

dpwa: Clean up fallout from user_display_mode migration bug

This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/2392168.

Background:
The above CL fixes a bug that caused bookmark app -> BMO migration to
set the user_display_mode to kBrowser for non locally installed apps.
The bug fix unfortunately doesn't fix the effects of that bug for users
that ran the migration code bug.

Change:
This CL specifically looks for users affected by the bug (where their
bookmark app is set to open in a window while the BMO app is set to
open in a tab) and re-migrates their bookmark app user_display_mode.

Known issues:
 - If the user sets their user_display_mode to open in browser tab
   after migration and before the clean up runs it will be reverted
   back to window (this is indistinguishable from the migration bug
   but should be rare).
 - This won't run for users with sync disabled (though they are
   unlikely to have this bug as sync is required to have
   non-locally installed bookmark apps).

Bug: 1127128
Change-Id: I4268fbf450760b0ef1403be209d1983fd83a8b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391704
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806888}