Google Git
Sign in
chromium / chromium / src / 1991342101e1af4947ca05cf3da08ea4228481bb
commit1991342101e1af4947ca05cf3da08ea4228481bb[log] [tgz]
authorDavid Benjamin <davidben@chromium.org>Mon Mar 25 13:21:47 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 25 13:21:47 2024
tree66ecf151abb8a609fbf61aa3b8179b60aa09c078
parentae5fb853bf7924bfbae1ffcb491d67804372e6ca [diff]
Specify the underlying type for UMALinuxGlibcVersion

enums are weird. They are neither limited to their listed values, but
nor are they plain ints. If an enum is neither `enum class ...` nor
`enum Foo : T`, its "underlying type" is not "fixed". In that case,
although it is typically sized like an int, the range of values is
defined by some bizarre "hypothetical integer type with minimal width"
rule.
https://eel.is/c++draft/dcl.dcl#dcl.enum-8

RecordLinuxGlibcVersion() specifically wants to store the full range of
uint32_t in the enum, so just specify an underlying type of uint32_t.
This fixes one of the two UBSan errors in this (and several other) test
failures:
https://luci-milo.appspot.com/ui/inv/build-8752555092756764593/test-results?q=All%2FAboutFlagsBrowserTest.ExpiryHidesFlag%2F0&sortby=&groupby=

Bug: 40942951
Change-Id: Ic4c9d41d64be4a7e1fae53792a78a6469a07bc57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390905
Reviewed-by: Erik Chen <erikchen@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277593}
1 file changed
tree: 66ecf151abb8a609fbf61aa3b8179b60aa09c078
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.