Google GitGoogle Git
Sign in
chromium/chromium/src/d3f7149fbb814488d77d2a8511ad6f023d6caa3e
commit
d3f7149fbb814488d77d2a8511ad6f023d6caa3e
[log]
author
Rachel Wong <wrong@chromium.org>
Wed Aug 04 06:24:41 2021
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Aug 04 06:24:41 2021
tree
46fee0078cc3c6a0af24109979926f8d9880429e
parent
caf1ba4cc8c524f2b9eefddcdf704b5c7b133cde [diff]
Return a valid but empty response if ItemSuggest returns no items.

The existing JSON conversion method in ItemSuggestCache returns
base::nullopt if there are no items in the response, which is then
interpreted as kJsonConversionFailure in the metrics.

This CL changes the behaviour to return empty Results instead, which
will be interpreted as kNoResultsInResponse for metrics. There should
not be any other effect.

Bug: 1234550
Change-Id: Ic55e1f574c71765408e4f7a2f694f9c05893ff45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3066781
Reviewed-by: Amanda Deacon <amandadeacon@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908351}
2 files changed
tree: 46fee0078cc3c6a0af24109979926f8d9880429e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.