commit | d3f723d09a4fa5cfbb0a969b98f25f116f8ada06 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Wed May 26 17:23:40 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 26 17:23:40 2021 |
tree | 1da967491462843193d0e447880ab4ccf3b46e53 | |
parent | 5ab5f586d05e2ad08650ef9f261ad22d3b8b1590 [diff] |
[GridNG] Add concept of "explicit"/"implicit" stretching. Previously on the constraint-space we had a bit which indicates of we should "stretch" of "shrink-to-fit" if the size in the particular direction is auto. This doesn't quite capture all the constraints however. For example: <div style="display: grid;"> <div style="aspect-ratio: 1/1; height: 100px;"></div> </div> <div style="display: grid;"> <div style="aspect-ratio: 1/1; justify-self: stretch; height: 100px;"></div> </div> In the above example both of the inline sizes are "stretched" however one is "implicit" (or weak - the default), and one is "explicit" (or strong). Various layout modes have different concepts here. Most of the time it is implicit, however flex layout defaults to "explicit"/"strong". This fixes the various grid aspect-ratio tests that was failing w/ GridNG enabled, and creates two additional passes: - grid-aspect-ratio-018.html - grid-aspect-ratio-019.html Bug: 1045599 Change-Id: Ifb8c4e010e85f53c020545ce077447d1f4312252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911763 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#886786}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.