commit d41e9bc12ca6f6493cfc77cd9d8bdc14b0059925
author luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> Mon Aug 12 11:26:22 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 12 11:26:22 2024
tree 022e08ca987217f1e91a9b3207646667733cf577
parent 778ed0b8845e8b20908f50af3668017a88f4a281

Revert "[Android] Remove workarounds for toolbar appearing under tab switcher"

This reverts commit 394a5b0c9aa96f29876e90d849b853f94324421b.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5717072848879616

Sample build with failed test: https://ci.chromium.org/b/8740040540588693393
Affected test(s):
[ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest#testNewTabPageIncognitoAppMenuItems](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest%23testNewTabPageIncognitoAppMenuItems?q=VHash%3A359dcabdb2bd6ffc)
[ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest#testNewTabPageRegularAppMenuItems](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest%23testNewTabPageRegularAppMenuItems?q=VHash%3A359dcabdb2bd6ffc)
[ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest#testOpenNewIncognitoTab](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest%23testOpenNewIncognitoTab?q=VHash%3A359dcabdb2bd6ffc)
[ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest#testOpenNewTab](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest%23testOpenNewTab?q=VHash%3A359dcabdb2bd6ffc)
[ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest#testOpenSettings](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.app.appmenu.TabbedAppMenuPTTest%23testOpenSettings?q=VHash%3A359dcabdb2bd6ffc)
and 16 more ...

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5717072848879616&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5777727&type=BUG

Original change's description:
> [Android] Remove workarounds for toolbar appearing under tab switcher
>
> Now that the ANDROID_HUB is launched, the buttons don't appear anymore
> in the tab switcher.
>
> Also create descendant() factory methods for ViewSpec to simplify
> declarations of ViewSpecs with isDescendantOfA().
>
> Bug: 41497463
> Change-Id: Ic17be0a350cea70cbd9c7195c62980c3b2f339c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777727
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1339914}
>

Bug: 41497463
Change-Id: I09169224f470c8e625119f7e83c31c417da511c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778156
Owners-Override: Friedrich Horschig <fhorschig@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1340313}