Google Git
Sign in
chromium / chromium / src / d4658038522bbb583275fe77237f4ffb5d441007
commitd4658038522bbb583275fe77237f4ffb5d441007[log] [tgz]
authorPeter Kasting <pkasting@chromium.org>Fri Jan 11 22:34:47 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jan 11 22:34:47 2019
tree26173d1f8408861f84497936e52b50e6f0d85ac3
parenta6e9f5e4a09a151127d74e91af341a92e20a484a [diff]
Make glass frame inactive border color better approximate native behavior.

The existing blend color/alpha were not accurate.  Update them.  Also, it seems
unnecessary (and gives a behavioral cliff) to do very different things for light
and dark toolbar colors.

Instead, just always compute the inactive border as if it's being blended atop
the inactive frame color, which won't look bad since that color is in the
adjacent pixel.

This has the added bonus of being simpler as well.

Bug: 659451
Change-Id: I4fd2aa9d24af266b590c6dfcc2cbc7c0c96e2e86
Reviewed-on: https://chromium-review.googlesource.com/c/1404395
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622192}
1 file changed
tree: 26173d1f8408861f84497936e52b50e6f0d85ac3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .