Rewire HoverButton's PressedCallback to support move-only callbacks.

PressedCallback will become non-copyable when it is updated to work with
OnceCallbacks. This causes problems since HoverButton uses its
PressedCallback for the actual underlying button, as well as passing a
copy to the button controller for it to handle additional events.

One potential solution is to use a trampoline RepeatingCallback and
populate HoverButton and HoverButtonController with two different
PressedCallback instances; this idea was discarded because:
- HoverButtonController gates a few behaviours based on whether the
  supplied PressedCallback is null or not, so HoverButton would have to
  conditionally create a trampoline RepeatingCallback only if the
  PressedCallback is not null.
- however, a PressedCallback holding a OnceCallback will become null
  after it is run, and there is no easy way of propagating that null
  state up the PressedCallback chain.

Instead, the solution here is to store the original PressedCallback on
HoverButton itself, and allow HoverButtonController to grab a reference
to the PressedCallback when needed.

HoverButton still needs to pass a trampoline PressedCallback to the
actual underlying button, but this does not have the same issues with
propagating null state up the chain; the underlying button only cares
about the null state to avoid running a null callback.

Bug: 1326449
Change-Id: I37f087c4a43cff942a756b62dc1d5441670bc101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5069913
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231412}
4 files changed
tree: 9fe2bb1f4a19bf7c6e47dd6accc0809cfea8595c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.