Google Git
Sign in
chromium / chromium / src / d4ffa99c94b1c4136fce8f4b430f1b982da8fe97
commitd4ffa99c94b1c4136fce8f4b430f1b982da8fe97[log] [tgz]
authorYuheng Huang <yuhengh@google.com>Fri Nov 03 16:46:58 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 03 16:46:58 2023
treeed62840823491055cb3e247a38b2fd095eb086a0
parent556d82b05c138c73fb6ce45b75776947095ebb84 [diff]
Revert "[CloudOpenMetrics] Add consistency checks for TaskResult kFailedToUpload"

This reverts commit 1d46742b706c861fea791bc7a1741462a42035ce.

Reason for revert: tree closure
https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-arm-generic-rel/113575/overview

Original change's description:
> [CloudOpenMetrics] Add consistency checks for TaskResult kFailedToUpload
>
> When TaskResult is logged with kFailedToUpload, there should be
> not OpenErrors and UploadResult must not be kSuccess.
>
> Bug: b/300861997
> Change-Id: I1a3ae67aa8d388a61b0a189902ee30f7ed4fe969
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003887
> Commit-Queue: Cassy Chun-Crogan <cassycc@google.com>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1219332}

Bug: b/300861997
Change-Id: I1d3b1f4296fe6439037c0e75a487dee370cca7a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005161
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Yuheng Huang <yuhengh@google.com>
Commit-Queue: Yuheng Huang <yuhengh@google.com>
Cr-Commit-Position: refs/heads/main@{#1219532}
2 files changed
tree: ed62840823491055cb3e247a38b2fd095eb086a0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.