Google Git
Sign in
chromium / chromium / src / d51e5b5efebe7b96ef6ce5331f28b7a482881818
commitd51e5b5efebe7b96ef6ce5331f28b7a482881818[log] [tgz]
authorFergus Dall <sidereal@google.com>Wed Feb 24 09:11:05 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 24 09:11:05 2021
tree06127dbc31f52776d47f043a6f54b8e5684b3dca
parent9e5b091083be96e69641b85725740598420fb61b [diff]
Move initialization and shutdown of DBusThreadManager out of CrostiniTestHelper

CrostiniTestHelper tries to be helpful by initializing and shutting
down DBusThreadManager as needed. In production however, keyed
services are always shutdown before DBusThreadManager, so
DBusThreadManager must not be shutdown before the profile has been
destroyed (which shuts down all keyed services tied too it). As
CrostiniTestHelper uses a profile managed elsewhere, it cannot manage
this.

This was causing failures in ShelfContextMenuTest.CrostiniNormalApp,
as some tasks from CrostiniManager would run after DBusThreadManager
was shutdown and expect to have access to DBus clients.

Bug: 1177126
Change-Id: Ia7777570da010c3ebad4c31d77a85a59a19a7934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2717603
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857074}
9 files changed
tree: 06127dbc31f52776d47f043a6f54b8e5684b3dca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.