Remove disabled no-op tests in offline_pages This change is part of the effort to re-enable consistently passing tests across the entire chromium. If the tests are reasonable, please LGTM and I will proceed to submit the change. If the tests are unreasonable, please let me know and I will remove them. I do not inspect each individual test case, the idea is to run the disabled tests on reviver builders https://ci.chromium.org/ui/p/chromium/g/reviver/builders and use the aggregated results to decide if a previously disabled test is now consistently passing. The following list shows how many times the changed tests were *consistently* passing on the relevant builders. components:components_unittests/OfflinePageModelTaskifiedTest.DeleteCachedPageByPredicate 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 193 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.DeleteCachedPageByPredicateUserRequested 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 194 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.DeleteMultiplePages 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 194 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.DeletePageNotFound 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 193 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.DeletePageStoreFailureOnRemove 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 194 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.DeletePageSuccessful 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 194 fuchsia-x64-rel 111 linux-lacros-builder-rel components:components_unittests/OfflinePageModelTaskifiedTest.SavePageOfflineCreationStoreWriteFailure 10 fuchsia-fyi-x64-asan 179 fuchsia-fyi-x64-dbg 193 fuchsia-x64-rel 111 linux-lacros-builder-rel Bug: 1380293, 781023 Change-Id: I6ae9044fe96424249b75476841b1e1a02176744e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412633 Commit-Queue: Zijie He <zijiehe@google.com> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/main@{#1129398}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.