Google Git
Sign in
chromium / chromium / src / d569a7abdc41abc88d41343682e2e8ee195eacb6
commitd569a7abdc41abc88d41343682e2e8ee195eacb6[log] [tgz]
authorRiley Tatum <rtatum@google.com>Fri Apr 12 16:57:36 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 12 16:57:36 2024
treef607428b0fdd2826d9f132551bb85ed0670827ed
parent93f4cbd5648840c384a64aa4c143fa3458b76df8 [diff]
[Customize] Stop button overflow for color scheme mode

When text was too long to fit all of the sections into the button, it
would just make the segmented-button-option wider than the overall
segmented-button (see bug for example video).

To handle this, min-width is set to 0 so the button-option will stop
using content as the min-width, causing the button-option to be larger
than the button. Also, as discussed in the bug, overflow text will be
hidden with ellipsis. Then, full text will be visible via tooltip on
hover.

Screenshots:
1 long word overflow: http://screenshot/7M6JFwjv6n6xhov
multi-word overflow: http://screenshot/BTLSYeY5yyr2XXQ

Bug: 41481914
Change-Id: Ied17c40e0c0b0e6a31408aa5eaa76a3fa8b65914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445927
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/heads/main@{#1286555}
3 files changed
tree: f607428b0fdd2826d9f132551bb85ed0670827ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.