Google Git
Sign in
chromium / chromium / src / d5718944a247a998d5fe565a66367a2021201fa0
commitd5718944a247a998d5fe565a66367a2021201fa0[log] [tgz]
authorDavid Benjamin <davidben@chromium.org>Wed Apr 16 20:44:33 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 16 20:44:33 2025
tree89a0417107dbd3c7e7650979789a55a7d212872e
parent799be5e132eb36551b4bd2b9d1b89d1b1b7e7595 [diff]
Disable the deprecated SecIdentitySearchCreate codepaths in ClientCertStoreMac

macOS provides two ways to search for identities, SecItemCopyMatching()
and SecIdentitySearchCreate(). SecIdentitySearchCreate() is deprecated,
as it relies on CSSM_KEYUSE_SIGN (part of the deprecated CDSM/CSSA
implementation).

We used to merge the results of the old and new APIs, to account for any
identities that were not returned by SecItemCopyMatching(), particularly
smartcard-based identities. It is unclear whether such identities still
exist, but the APIs have been deprecated since 10.7. Disable the old
codepath on the assumption that Apple's APIs behave as documented. If we
run into issues, I've left a base::Feature that can turn the codepath
back on as needed.

This is a speculative fix for crbug.com/408462957, which is a crash
somewhere in Apple's system libraries, via this deprecated codepath.

Bug: 40233280, 408462957
Change-Id: Ic64a1a048a469288b582767394f3cc82fada0a19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462461
Commit-Queue: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1447988}
3 files changed
tree: 89a0417107dbd3c7e7650979789a55a7d212872e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.