Google Git
Sign in
chromium / chromium / src / 30645e2f17efd8cfaf09c6f332cdf333282d2ef7
commit30645e2f17efd8cfaf09c6f332cdf333282d2ef7[log] [tgz]
authorPeter Williamson <petewil@chromium.org>Thu Mar 07 00:32:40 2019
committerCommit Bot <commit-bot@chromium.org>Thu Mar 07 00:32:40 2019
treec974bd280c8c567e3051937005d27438c095e891
parentcdc92f96b8b0e231e1e6c9cc173c9c473d10e908 [diff]
Revert "Refactor SSLCertificateErrorPageController"

This reverts commit 08c128cd49af9bfb4ded6298441e158b41849061.

Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11

TBR: carlosil@chromium.org

failures:
SSLClientSocketReadTest.Read/1
SSLClientSocketReadTest.Read/0
HTTPSEVCRLSetTest.FreshCRLSetNotCovered
WebSocketEndToEndTest.BasicSmokeTest
SSLClientSocketReadTest.DumpMemoryStats/0
SSLClientSocketReadTest.DumpMemoryStats/1
URLRequestTestFTP.FTPCheckWrongUser
WebSocketEndToEndTest.TruncatedResponse
WebSocketEndToEndTest.HstsWebSocketToWebSocket
WebSocketEndToEndTest.TrailingWhitespace
HTTPSOCSPTest.IntermediateResponseTooOld
URLRequestTestFTP.FTPCheckWrongUserRestart
URLRequestTestFTP.FTPCheckWrongPasswordRestart
HTTPSOCSPTest.Revoked
HTTPSFallbackTest.TLSv1_1NoFallback
HTTPSFallbackTest.TLSv1_3Interference
URLRequestTestFTP.FTPCheckWrongPassword
WebSocketEndToEndTest.HeaderContinuations
HTTPSCRLSetTest.ExpiredCRLSetAndRevoked
HTTPSEVCRLSetTest.FreshCRLSetCovered
SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1
SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18
HTTPSOCSPTest.Valid
HTTPSEVCRLSetTest.ExpiredCRLSet
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16
… 70 more (100 total) …

Original change's description:
> Refactor SSLCertificateErrorPageController
>
> SSLCertificateErrorPageController is no longer only used on SSL errors,
> renamed it to SecurityInterstitialErrorPageController, and removed the
> net::Error code passed to EnablePageHelperFunctions since it's no
> longer used.
>
> Bug: 910794
> Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638232}

TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org

Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638363}
11 files changed
tree: c974bd280c8c567e3051937005d27438c095e891
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .