Revert "[Tab Group] Refactor show/hide code for bottom tab strip" This reverts commit 47b7b38aea9bcbcd91748e1952b0142121614ed7. Reason for revert: TabGroupsTest#testTabGroupModelFilterObserverUndoClosure is failing on builder "android-arm-tests": http://b/382401210 Original change's description: > [Tab Group] Refactor show/hide code for bottom tab strip > > Significantly refactor/simplify tab group bottom strip show/hide logic. > The previous implementation tried to special case every observer event. > This new approach is much simpler. On any update event we run the same > logic. > > Steps: > 1) Check if we can show, there are several reasons this UI can be > suppressed. If it is suppressed we hide if not already hidden. > 2) If the current tab's tab group ID matches the ID we used last > time we do nothing. Otherwise we perform an update to either show the > new group (if non-null tab group ID) or hide. > > State tracking is limited to the last known tab group ID which is more > descriptive than a boolean. This approach would not have been possible > with the non-stable root IDs used previously. > > Fixed: 380920457 > Change-Id: I3b890e9aa93f24fd869a3f48d3256a3716a7e711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6069911 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1391890} Bug: 380920457, 382401210 Change-Id: I631fe4eaafa1dcaff0069c810256ae8e55ed6312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072606 Auto-Submit: Kartar Singh <kartarsingh@google.com> Owners-Override: Kartar Singh <kartarsingh@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1392117}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.