commit | d5bbc69884ce9cc8f738b665030607b598d2107e | [log] [tgz] |
---|---|---|
author | Jocelyn Tran <jocelyntran@google.com> | Fri Jan 31 22:08:35 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 31 22:08:35 2025 |
tree | 48658c6205de20e90469e5dd2e9c7a6b6d862782 | |
parent | 958e32a827bacac75a325149d6f648011c4cacba [diff] |
Revert "[A11y] Allow children for br elements in all cases" This reverts commit 8755f33cb11a1a1d041c3e0687b2a4524a119627. Reason for revert: Original change caused clusterfuzz bugs. Original change's description: > [A11y] Allow children for br elements in all cases > > Line breaks in the accessibility tree normally contain a single inline > textbox child. However, if a script adds a DOM child to the line break, > that child is not added to the accessibility tree, and the textbox child > is removed. > > This removal causes a mismatch between the accessibility tree's node > count (from the AXObjectCache) and the serialized tree's node count > (from the AXTreeSerializer). > > Since Blink doesn't render script-added DOM children on line breaks, and > these children aren't in the layout tree, always including the inline > textbox child in the accessibility tree (even when a script adds a DOM > child) resolves the node count mismatch and aligns the accessibility > tree more closely with the layout tree. > > Bug: 382551990,382732986 > Change-Id: I65d6e88ea3489096948c726dcfc582bf2f5ca33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108264 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Jocelyn Tran <jocelyntran@google.com> > Cr-Commit-Position: refs/heads/main@{#1411753} Bug: 382551990,382732986,393411206,393408789 Change-Id: Ie3982d19f2e6d013ed8e359804d9c94787bde935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216715 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Jocelyn Tran <jocelyntran@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1414399}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.