commit | d5dd931e0ad3d9ffe74888ec62a3cc106efd7ea6 | [log] [tgz] |
---|---|---|
author | Ian Vollick <vollick@chromium.org> | Tue Oct 03 16:49:46 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 03 16:49:46 2023 |
tree | 09628e97bc450c4a7cf63539a2dd90b24d647dd0 | |
parent | 7ca62d6208008cd5d5c2c20a7541f97b368edeb8 [diff] |
Deduplicate batched cookie access details With this CL, we use a std::set to ensure that we avoid sending IPCs with redundant cookie access details. Some clients care about counts, so we include a count along with the deduplicated details. The order of the elements are determined by the position that the last duplicate would have occupied in the non-deduplicated list. Eg, consider the following: ABACCABACDA ^ ^^^ The caret is below the last instance of each duplicated entry. We take the elements with the carets and return them in this order: BCDA. I also noticed that the cookie list was not used in OnCookiesRead so I've removed that plumbing in this patch as well. credit: dtapuska@ for suggesting that we avoid storing redundant data, suggesting a dictionary-like data with counts, and checking for compression percentage. jbroman@ for suggesting std::tie/ make_tuple for combining r and l values for comparison. Bug: 1393050 Change-Id: Ifadbc3f1787f251fe405454c5d2c99287eea90ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803411 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204707}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.