Move to an options variant for Show method in GlicInstanceImpl This CL introduces `ShowOptions` as a variant to manage different Glic UI embedder types, such as the side panel and floating UI. This change improves type safety and decouples conversation switching logic from the specific UI embedder. `ShowOptions` also allows passing additional information for showing a UI that doesn't belong in the `EmbedderKey`. Key changes: - Introduced `glic::ShowOptions`, `glic::SidePanelShowOptions`, and `glic::FloatingShowOptions` to represent different ways to show the Glic UI. - Removed the now-unnecessary `GlicInstanceImpl::EmbedderType` enum in favor of the `ShowOptions` variant. - Updated `GlicInstanceImpl` and `GlicInstanceCoordinatorImpl` to use `ShowOptions`. - `SwitchConversation` is now embedder-agnostic, simplifying the logic. Fixed: b:450562729, b:450680703 Change-Id: I6a6a6964f47c81e352dd03461ff06d53153dc202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032584 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1528439}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.