| commit | d5ff606949a23e531b40c23f112bbcd71de3cebd | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@chromium.org> | Thu Jun 06 16:35:44 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 06 16:35:44 2024 |
| tree | 92414a41f0b7204851fbf5e697dbbd72cc3b2194 | |
| parent | e8ff120f6af274e1889cec2fe648a3af07a8ec45 [diff] |
Retry rolling crates that have been missed by earlier attempts. Problem description =================== The `create_update_cl.py` tries to generate small, incremental update CLs. To do this, it tries to update one create at a time (in an order based on the size of the crate's update). Sometimes this produces an empty diff - e.g. when the crate cannot be updated without first (or also) updating its dependencies. Such failed update attempts will not produce an update CL. In most the skipped crate will be covered when processing other, related crates (e.g. usually updating `cxx` also updates `cxxbridge-flags` and `cxxbridge-macro`). But before this CL, the skipped crate will just be ignored - e.g. sometimes `skrifa` cannot be rolled without first updating `font-types` and `read-fonts` but updating those other 2 crates doesn't cover `skrifa`. Changes in this CL ================== After this CL, the `create_update_cl.py` script will retry updating crates that haven't been covered by the initial pass through `todo_crate_ids`. I've manually tested that this would cover `skrifa` when starting from `735e580f7914ba6f5ddaebe9702ecde86dcc79f0^`: ``` ** Retrying 1 crates. Updating skrifa@0.19.2 to a newer version... Running `gnrt update skrifa@0.19.2` ... Running `git mv <old dir> <new dir>` (for better diff)... Running `gnrt vendor`... Running `gnrt gen`... ``` Bug: None Change-Id: I4a231ca730060c882bb746b68b18f0bebb5f0a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5601970 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1311334}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.