commit | d60aaeea8014c75e2ac421c244b51d38dbef197e | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Mon Jun 20 11:01:53 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 20 11:01:53 2022 |
tree | 2b1892c6a6e8773917b2697f7eac02fb22273fc7 | |
parent | 062e3229f0ba6c168489a1131879fef8061b95d3 [diff] |
[Preconnect] Stop specially prioritizing preconnect tasks This CL eliminates the execution of preconnect tasks on a custom high-priority task queue that was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1527536, reverting back to the behavior prior to that CL of executing these tasks on the default (priority-based) task queues. We have done experimentation and found that execution on the custom high-priority task queue brought no performance benefits over execution on the default priority-based task queues (summary in https://bugs.chromium.org/p/chromium/issues/detail?id=1257582#c28). Specifically, this CL is implementing the launch of the NoStandaloneQ arm of the experiment analyzed on that bug. The logic for why this is the case bears explicit mention: - NoStandaloneQ enables the "kTreatPreconnectTaskTypeAsDefault" base::Feature. - When this feature is enabled, invoking GetUIThreadTaskRunner({BrowserTaskType::kPreconnect}) returns the task runner for the task priority of the BrowserTaskTraits instance created via {BrowserTaskType::kPreconnect}. This task priority is USER_BLOCKING, since BrowserTaskTraits inherits the default value from TaskTraits and doesn't modify that default value. - In this CL, we simply stop passing a TaskRunner to the calls to BindNewPipeAndPassRemote() made in the preconnect code. When no TaskRunner is explicitly specified to these calls, they use SequencedTaskRunnerHandle::Get(). The task runner returned by SequencedTaskRunnerHandle::Get() on the UI thread (on which these calls are executing) is also the task runner for the USER_BLOCKING priority, i.e., the same task runner that is currently being passed when kTreatPreconnectTaskTypeAsDefault is enabled. This CL also eliminates the kPreconnect browser task trait, as there are now no uses of it in the codebase. Bug: 1257582 Change-Id: Idecfb145cd3299c38e5e479385e5dccdab2e0056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698086 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1015858}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.