Blink: Have OffscreenCanvasRC2D::WritePixels call FlushRecording()

OffscreenCanvasRenderingContext2D::WritePixels() currently calls
FinalizeFrame(). This method does the following:
1. Calls GetOrCreateResourceProvider(), short-circuiting out if the
   method returns null
2. Short-circuits out if Host() returns null
3. Calls Host()->FlushRecording()

In this context, (1) and (2) are unnecessary:

* WritePixels() makes the same GetOrCreateResourceProvider() call and
  short-circuits out if it returns null just before calling
  FinalizeFrame(). GetOrCreateResourceProvider() is idempotent if
  called multiple times consecutively.
* WritePixels() calls Host() without null-checking directly below (and
  indeed, GetOrCreateResourceProvider() will return null if Host()
  returns null)

This CL replaces the FinalizeFrame() call with a direct call to
FlushRecording(). In addition to being simpler, this aligns the
structure with that of Canvas2DLayerBridge::WritePixels() - a step
toward our goal of moving the two impls into one common implementation
in BaseRenderingContext2D.

Bug: 348445884
Change-Id: I3269a334f1a1b2fe23e554cdb9615c7d3753a1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5816871
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1347863}
1 file changed
tree: 9d81723311c14c95af86d5106d5e07410e4704a8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.