| commit | d63bf43d9f9e4bbb88c67b3bcd586d53cdf01ed7 | [log] [tgz] |
|---|---|---|
| author | Paul Adedeji <pauladedeji@google.com> | Fri Jun 28 19:09:53 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 28 19:09:53 2024 |
| tree | 8109dd598144f1e566e18b20bf758be8a005e923 | |
| parent | c5b10f1a247a803d2271e07be2f51410bea8f110 [diff] |
Attempt to de-flake test in table_test.ts. Problem: The test flakes during the first check of `openTabButton1`'s style (`assertStyle(openTabButton1, 'display', 'none');`). Most likely solution: await `flushTasks()` instead of `waitAfterNextRender` in case there's a race condition. Also, check if the buttons are visible using `isVisible` from `test_util.js` instead of `assertStyle`, as this is the recommended way to check visibility. Change-Id: Ib6b30f2f63b613f6bc6e7d318f189ed45b994096 Bug: 342635241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5664169 Commit-Queue: Paul Adedeji <pauladedeji@google.com> Auto-Submit: Paul Adedeji <pauladedeji@google.com> Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1321113}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.