Google Git
Sign in
chromium / chromium / src / d65ca03e13a291fbcf75d1a8dd40ab80e46fdee5
commitd65ca03e13a291fbcf75d1a8dd40ab80e46fdee5[log] [tgz]
authorKramer Ge <fangzhoug@chromium.org>Mon Aug 26 16:00:56 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 26 16:00:56 2024
treec4f6156de1060ed7cd9c3f5d6c91edba724e94c5
parent42dbcf80b14c950182f50b562d015a31d1d21bd9 [diff]
Exit GLContextEGL Initialization if Config is NULL

We are seeing a group of gpu crashes that occur at engle
glGetConfigAttrib, with SEGV_MAPERR @0x0000006c. 0x6c is the member
offset for egl::Config::renderableType, which means the egl::Config is
NULL. Unclear yet why chrome running on a VM with 0x0 as gpu vendor
does not fallback to software mode earlier and crashed here.

Adding a guard to early out the context initialization here for now, it
should help gpu fallback to software mode.

Bug: 359987747
Change-Id: Ia335e8d13246af6b3c9eecb9ee3c1be011eecdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5806075
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1346757}
1 file changed
tree: c4f6156de1060ed7cd9c3f5d6c91edba724e94c5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.