Google Git
Sign in
chromium / chromium / src / d679b251318aaa4b3bc31b327b1147da41c63819
commitd679b251318aaa4b3bc31b327b1147da41c63819[log] [tgz]
authorFriedrich Horschig <fhorschig@chromium.org>Thu May 19 12:53:34 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 19 12:53:34 2022
tree77f32e0699baa8c089917c4d707189bd3559b451
parentdfb2e8d040489cc869848afd69d4dba6b87ba5be [diff]
[Android][UPM] Fix crash in TouchToFill due to accessing offscreen items

Before this CL, the loop that changed the backgrounds assumed incorrect
indices due to the usage of RecyclerView.State#getItemCount:
a) the 1st item is not necessarily the header (e.g. if it's off screen)
b) the last item is not necessarily on screen

b is especially surprising since it caused the crash in the linked bug.
Against all expectations, the number of items in the state exceeds the
visible items. Using the general ViewGroup#getChildCount fixes that and
in turn the crashes.

Because we use the adapter positions and the total count of items in the
adapter to compute the background drawable, it should also be correct if
some items are off-screen (which wasn't an observed but a plausible
issue).

(cherry picked from commit 2e8035f71398ef495e0838d145fff40d99c8aa1e)

Bug: 1325333
Change-Id: Ib2004c77aefa7306640042e326c1969c6ff0bb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651980
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004686}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3655435
Auto-Submit: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#104}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: 77f32e0699baa8c089917c4d707189bd3559b451
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.