Google Git
Sign in
chromium / chromium / src / d6809fb4549c9496e05af7559c448349c6c36ff1
commitd6809fb4549c9496e05af7559c448349c6c36ff1[log] [tgz]
authorBen Reich <benreich@chromium.org>Thu Apr 04 06:34:07 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 04 06:34:07 2024
tree0ad4e64cdc5fa86afba496754637110a4d0f408d
parent3966b91c1b7f5fece270550bed7cdec61a2dffee [diff]
[FspCache] Update OpenFileSuccess to fallback to GenericSuccess

CL:5343674 introduced a new optional callback to the OpenFile FSP
method. This required setting up a new OpenFileSuccess operation that
enabled passing the result back. In doing so it extended the
FSPOperation enum. In the case that the LaCrOS version is running the
IDL with the changes from CL:5343674 and Ash is not running with these
changes (e.g. LaCrOS is M125+ and Ash is <=124) then the forward will
fail (the FSPOperationResponse will default to kUnknown).

To avoid this and enable a graceful degradation, this splits out the
OpenFileSuccess operation to its own interface method to enable version
validation on the mojo remote. In the event the method is not supported
it will fall back to a GenericSuccess and strip the supplied base::Value
supplied to the callback.

Bug: b/331722180
Change-Id: I7b3f8591d9777844da7d0a704724446731707478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5411572
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ben Reich <benreich@chromium.org>
Reviewed-by: Alexander Bolodurin <alexbn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282336}
6 files changed
tree: 0ad4e64cdc5fa86afba496754637110a4d0f408d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.