commit | d693245da1a31f689081bf055a259d8138c27182 | [log] [tgz] |
---|---|---|
author | Eitan Goldberger <eitang@google.com> | Mon Feb 05 15:23:33 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 05 15:23:33 2024 |
tree | ed2982aa98e85de341d1f65255ab62a2904be52a | |
parent | 101dce498cda58a4d3342c0edf129315b2fa779f [diff] |
Add a field to track whether speech pause is triggered from the play/pause button toggle. This is because we want to differentiate between pauses that come from the play/pause button from pauses that come from a menu selection. For the play/pause button, we want to call synth.pause() then synth.resume(), because this continues reading from the word that was paused. For menu changes, we want to call synth.cancel() then synth.play(), because this allows the menu changes to take effect and shows the user that the app is responsive to their changes. However, synth.cancel() and synth.play() starts speaking from the beginning of the utterance. This is why we don't want to use this for the play/pause button. This will change when we handle word level tracking, but for now we need this temporary code change. Bug: 1474951 Change-Id: I9a3c3223d978d46b220da23c90d933d336bd3e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262559 Reviewed-by: Lauren Winston <lwinston@google.com> Commit-Queue: Eitan Goldberger <eitang@google.com> Cr-Commit-Position: refs/heads/main@{#1256215}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.