Google Git
Sign in
chromium / chromium / src / d6db84a259a0a6c7de2da1d54e3a1875280c0331
commitd6db84a259a0a6c7de2da1d54e3a1875280c0331[log] [tgz]
authorPeng Huang <penghuang@chromium.org>Fri Feb 04 18:02:46 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 04 18:02:46 2022
treeb4ab21185c8542db745e13aa0546b2cae2e8d796
parentdf5bf69ebda670aed41f83c8896adc620be981b5 [diff]
AngleVulkan: fix BlitFramebuffer errors with WebGL

The problem is because WebGL requests creating AngleVulkan backing
with RGBX_8888 format, and AngleVulkan will create a R8G8B8A8
VkImage and then create an EGLImage from the VkImage. When we bind
the EGLImage to a gl texture, ANGLE will read the format from the
VkCreateImageInfo, and consider the gl texture's internal format
is GL_RGBA8. So when WebGL tries to call glBlitFrameBuffer(), the
read and draw buffers will be in different formats. It causes GL
errors. Fix the problem by providing the internal format to
eglCreateImageKHR.

Bug: 1290638
Change-Id: I9c9a8d708893bf08320877a4e3a663c9e7168547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3437564
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967328}
3 files changed
tree: b4ab21185c8542db745e13aa0546b2cae2e8d796
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.