commit d6e161a91a54b86273120f4159a202b49d9cfa87
author Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Fri Mar 29 00:17:37 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 29 00:17:37 2024
tree 1bb9877a544ab4ab1693ba8087988c232db31ec3
parent 6f22676a0d26b1bb0348268bf5a362c3739db166

Add CDP commands for manipulating Device Posture without other device overrides

Relying on SetDeviceMetricsOverride() does not work in WebDriver for a
number of reasons:
1. Some parameters are mandatory, but there is
   "GetDeviceMetricsOverride()", and even though we can infer some
   values for the parameters from other sources, actually setting them
   to non-zero values in SetDeviceMetricsOverride() causes them to be
   fixed to those values until ClearDeviceMetricsOverride() is called.
2. Not setting optional parameters also has effects, as it causes some
   default overrides to be set, and also remain with the same values
   until another call to SetDeviceMetricsOverride() or until
   ClearDeviceMetricsOverride() is called.
3. Having one call that changes multiple aspects does not work well if
   we just want to set a Device Posture override. It will reset any
   viewport segment overrides, and vice-versa, for example.

We could fix 2) and 3) by exposing some getters for the current values
and not doing anything if we're setting them to the same ones, but 1) is
harder to solve because the current semantics and syntax are stable in
CDP.

For now, the easiest approach is to expose new CDP commands that only
manipulate Device Posture overrides. The existing Device Posture code in
the SetDeviceMetricsOverride() implementation in Blink simply calls the
same override-related commands in DevicePostureProviderImpl via Mojo, so
the behavior in these commands is essentially identical.

The tests were copied from http/tests/inspector-protocol/device-posture
and slightly adapted to also include clearDevicePostureOverride().

Bug: 330376761
Change-Id: I3285ae8fc56c068653ae9136c1a16131a96ce754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401658
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/main@{#1280013}