commit | d728320ec97584c0bf68ed4d640daf247fcb3e79 | [log] [tgz] |
---|---|---|
author | Dave Tapuska <dtapuska@chromium.org> | Fri Dec 03 16:22:45 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 03 16:22:45 2021 |
tree | 3e33400fa08f7cf2dbf4aa27e5d9720f029b9ee2 | |
parent | 447cf38fa017562693b1972305b609cfb0279965 [diff] |
Fix a few static analysis errors. Issues N1, N2, N8 in https://pvs-studio.com/en/blog/posts/cpp/0893/ xslb was duplicated. widget's parent was accessed before a subsequent null check. client_ is DCHECKed to be non-null in the ctor. BUG=1275942 Change-Id: If127fbf3e757ccf63ec4ce0afa139a4d261499af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313879 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#948018}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.