Google Git
Sign in
chromium / chromium / src / d753cf84e60fb06fae471e3919b1308867228e0b
commitd753cf84e60fb06fae471e3919b1308867228e0b[log] [tgz]
authorDaniel Cheng <dcheng@chromium.org>Thu Mar 14 08:30:19 2024
committerEriko Kurimoto <elkurin@chromium.org>Thu Mar 14 08:30:19 2024
tree40829e8e1439b1a3b5308009fa4ef88606c1486e
parent985ab91e04205a97f6c7580974e371e30182b230 [diff]
Revert "mojo: Make shared message IDs strongly typed"

This reverts commit 0469e1d841fc110f13b8453b57e56bcb13cf7d2c.

Reason for revert: broke the build: https://ci.chromium.org/ui/p/chromium/builders/ci/android-x86-rel/64273/overview
gen/services/viz/public/mojom/compositing/compositor_frame_sink.mojom.cc:364:58: error: no member named 'kCompositorFrameSink_SubmitCompositorFrame_Name' in namespace 'viz::mojom::internal'

Original change's description:
> mojo: Make shared message IDs strongly typed
>
> This change changes Mojo's interface message IDs from
> generic `constexpr uint32_t` to interface specific enum classes.
>
> Design doc: http://go/predictive-mojo-allocation
>
> BUG=40278139
> TEST=Try jobs
>
> Change-Id: I4434ae6611ee947d18f40b7ea1e69cb45da8edc0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353690
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1272621}

Bug: 40278139
Change-Id: Ida1b9d3669047b605e96baa02c5a13942fd93eb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371095
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272624}
3 files changed
tree: 40829e8e1439b1a3b5308009fa4ef88606c1486e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.