Google Git
Sign in
chromium / chromium / src / d7875e946b80b7e704b091af323c8af8af90bb5f
commitd7875e946b80b7e704b091af323c8af8af90bb5f[log] [tgz]
authoranthie@google.com <anthie@google.com>Fri Jun 30 15:23:09 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 30 15:23:09 2023
treeb02e51ea1586a1f8b0ad3220764a2c0311701713
parentc116863335ae04135c2225d991d01bba4683ab74 [diff]
Fix regression in creating permission requestor in CAS

The refactoring of Child Account Service (CAS) and the move
to components introduced a regression in the creation
of Permission Request Creators in the method `SetActive`.

This change re-instates the previous used logic for the
creation on Permission Request Creators. A new instance
of Permission Request Creator will be created each time
`SetActive` is called, through a repeated callback provided
in the constructor.

A new test case is added to ensure a new Permission Request
Creator instance is called on re-activation of CAS.

Bug: b/289347521
Change-Id: Id94f6135c7b15698cd50c3cbdeee3d79fe44a85c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4656778
Reviewed-by: James Lee <ljjlee@google.com>
Commit-Queue: Anthi Orfanou <anthie@google.com>
Cr-Commit-Position: refs/heads/main@{#1164695}
5 files changed
tree: b02e51ea1586a1f8b0ad3220764a2c0311701713
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.