Google Git
Sign in
chromium / chromium / src / d7916252193b76195e78d5274a0f27fad79ca265
commitd7916252193b76195e78d5274a0f27fad79ca265[log] [tgz]
authorAdam Psarouthakis <psarouthakis@google.com>Tue Sep 13 23:48:44 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 13 23:48:44 2022
treed578dab7b7ce501ba0f050ef36d20a714d58d7fe
parent7068154ce71cbc73a6d9d8bd99003d630207d74d [diff]
Fix UploadPersistedFile file validation method

The UploadPersistedFile function should validate persisted files by parsing them to the active_report. This ensures the file is a proper serialized protobuf. Instead the current behavior overwrites the active report to the persisted data, which results in one file being uploaded repeatedly. Added additional unit test to validate this change.

Bug: 1360449
Change-Id: I416bfcc63036aaf53ffd63f43c7e308b1dab06cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3876327
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Adam Psarouthakis <psarouthakis@google.com>
Cr-Commit-Position: refs/heads/main@{#1046647}
2 files changed
tree: d578dab7b7ce501ba0f050ef36d20a714d58d7fe
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.