commit | d7aff8028d9c27ad8a90525d69db88ec9a2a3c13 | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Wed Jan 08 03:45:13 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 08 03:45:13 2025 |
tree | 6856191dbfcb187ae00f281cb9a843cfa9dd67bb | |
parent | c4aa56be5a89ab92f815c1d5455b45b08c3274e2 [diff] |
Revert "Apply resampling and filtering to back transition gesture" This reverts commit 11fd863068f9fc42df0e5345cda74edc89379060. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5583115201282048 Sample build with failed test: https://ci.chromium.org/b/8726372260772879841 Affected test(s): [ninja://content/test:content_browsertests/All/BackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestLivePageTransformBackNavigation/LTR](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FAll%2FBackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestLivePageTransformBackNavigation%2FLTR?q=VHash%3A6e0f9c1d8add64dd) [ninja://content/test:content_browsertests/All/BackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestLivePageTransformBackNavigation/RTL](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FAll%2FBackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestLivePageTransformBackNavigation%2FRTL?q=VHash%3A6e0f9c1d8add64dd) [ninja://content/test:content_browsertests/All/BackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation/LTR](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FAll%2FBackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation%2FLTR?q=VHash%3A6e0f9c1d8add64dd) [ninja://content/test:content_browsertests/All/BackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation/LTRFractionalDSF](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FAll%2FBackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation%2FLTRFractionalDSF?q=VHash%3A6e0f9c1d8add64dd) [ninja://content/test:content_browsertests/All/BackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation/RTL](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FAll%2FBackForwardTransitionAnimationManagerBothEdgeBrowserTest.TestScreenshotTransformScrimColorForwardNavigation%2FRTL?q=VHash%3A6e0f9c1d8add64dd) and 1 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5583115201282048&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6064026&type=BUG Original change's description: > Apply resampling and filtering to back transition gesture > > To improve the smoothness of the gesture. > > This moves the code to set up translations to OnAnimate, which has a > reference timestamp for the vsync. > > Because this adds lag, it exposed a bug in the cancel spring where the > direction of the initial velocity was wrong, leading to an excessive > rebound on the left edge. > > Bug: 383163623, 40945408 > Change-Id: I1f0ebab932aa2477bb686e3cc277cdbf8575247b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6064026 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: William Liu <liuwilliam@chromium.org> > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1403106} > Bug: 383163623, 40945408 Change-Id: I761410b15e95f151865172ff0d0a1ba21b9b7542 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6154719 Owners-Override: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403379}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.