Revert "Compare vector icons by address, not name." This reverts commit be7d966f20f546cfb5f04fef5871bac07ca20ff4. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6255047466811392 Sample build with failed test: https://ci.chromium.org/b/8723183395685237841 Affected test(s): [ninja://ash:ash_unittests/BluetoothFeaturePodControllerTest.HasCorrectMetadataWhenOff/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FBluetoothFeaturePodControllerTest.HasCorrectMetadataWhenOff%2FAll.0?q=VHash%3A09a1217d4f1b1e5e) [ninja://ash:ash_unittests/BluetoothFeaturePodControllerTest.HasCorrectMetadataWhenOff/All.1](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FBluetoothFeaturePodControllerTest.HasCorrectMetadataWhenOff%2FAll.1?q=VHash%3A09a1217d4f1b1e5e) [ninja://ash:ash_unittests/BluetoothFeaturePodControllerTest.HasCorrectMetadataWithMultipleDevice/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FBluetoothFeaturePodControllerTest.HasCorrectMetadataWithMultipleDevice%2FAll.0?q=VHash%3A09a1217d4f1b1e5e) [ninja://ash:ash_unittests/BluetoothFeaturePodControllerTest.HasCorrectMetadataWithMultipleDevice/All.1](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FBluetoothFeaturePodControllerTest.HasCorrectMetadataWithMultipleDevice%2FAll.1?q=VHash%3A09a1217d4f1b1e5e) [ninja://ash:ash_unittests/BluetoothFeaturePodControllerTest.HasCorrectMetadataWithOneDevice/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FBluetoothFeaturePodControllerTest.HasCorrectMetadataWithOneDevice%2FAll.0?q=VHash%3A09a1217d4f1b1e5e) and 22 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6255047466811392&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6236841&type=BUG Original change's description: > Compare vector icons by address, not name. > > Icons are globally unique and non-copyable, so comparing by address is > valid, and more efficient than a string comparison. > > Bug: 364987728 > Change-Id: I53dfec9d4ad533532670fce2f37d2f730f131448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6236841 > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1418983} > Bug: 364987728 Change-Id: I97d677b53d017cedcda41bd502e7a2975ded289c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253808 Reviewed-by: Taiyo Mizuhashi <taiyo@chromium.org> Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org> Owners-Override: Taiyo Mizuhashi <taiyo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1419082}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.