[Autofill] Relax the requirements for credit card import

Before this CL, a necessary requirement for credit card import
was that there are no two fields of the same type with non-empty
value.

This CL weakens this requiments as follows.

Firstly, we drop the above requirement. Instead, we now check if
the values are equivalent. If not, we reject import.

Secondly, we now rank fields by priority: (1) user-edited fields,
(2) autofilled fields, (3) others. Fields of different priority
may have inconsistent values: the lower priority value is ignored.

For example, consider a form
  Full name:  <input autocomplete=name>
  First name: <input autocomplete=given-name>
  Last name:  <input autocomplete=family-name>

Scenario 1: the user typed "Donald Trump", "Donald", and "Trump",
respectively. Then we offer import because the the values are
consistent.

Scenario 2: the user typed "Donald J. Trump" and autofilled "Donald"
and "Trump". Then we offer import for "Donald J. Trump" because
typing trumps autofilling.

Bug: 1381477
Change-Id: I79db1e2879049c219385b69ff981426d512c8e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018128
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Dominic Battre <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1238499}
7 files changed
tree: acffaf56f71bd03f643b77b072e6388701128075
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.