Add aura::Window::GeWeakPtrAsWindow()

This CL moves the WeakPtrFactory from GestureConsumer to subclasses,
and define WeakPtr getter for Window type, so that we can use the
same factory instance for super class and base casses, but still
use WeakPtr<aura::Window> but not WeakPtr<ui::GestureConsumer>.

Background:
There are increasing report w.r.t. dangling ptr for a window that can
be destroyed during a method call. This is to simplify the code
to deal with such situation (e.g. using WindowTracker or observers).

The weak pointer factory should be the last element in the class
structure, and there is no clean way to cast base::WeakPtr<Super>
to base::WeakPtr<Sub>.

C++ doesn't support covariance for template, so we can't just
define base::WeakPtr<aura::Window> GetWeakPtr.

And replced WindowTracker that tracks single window with Weakptr.

Bug: None

Change-Id: Ifc993908f56d34e3b694a9d10e26974097923e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7846473
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1630665}
17 files changed
tree: 2a1d8eb1a7861dd71779b7b24084b74d36e3183b
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .vpython3
  66. .yapfignore
  67. ATL_OWNERS
  68. AUTHORS
  69. BUILD.gn
  70. CODE_OF_CONDUCT.md
  71. codereview.settings
  72. CPPLINT.cfg
  73. CRYPTO_OWNERS
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. package.json
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.