commit | d879e9f170b35f42cae637fbcd99eaff39b13c95 | [log] [tgz] |
---|---|---|
author | Nate Fischer <ntfschr@chromium.org> | Tue Feb 05 00:07:22 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 05 00:07:22 2019 |
tree | cd5d0dc2579ab81aab84c565684f3f73e413ad4a | |
parent | fd91d711b6669f62e4ffc3dce21e6ae88ab16caf [diff] |
AW: workaround empty ReasonPhrase ReasonPhrase may legitimately be "empty" for HTTP/2 (and, even for HTTP 1.1). Unfortunately, when we call the WebResourceResponse constructor in the WebViewClientCompat code path, this constructor throws an exception (it wrongly asserts we provide a reasonPhrase). We must call this version of the constructor in this code path, since the less-restrictive constructor is only available on >= M (and we must support L). This only applies this workaround for the WebViewClientCompat code path, since there's little justification to faking out the ReasonPhrase except to avoid the crash. This skips automated tests, since that would require an HTTP/2 test server (which I don't believe we support). R=changwan@chromium.org Bug: 925887 Test: Manual - load https://putsreq.com/lSTsA2yWOJ3I6vXgLv2z (this \ Test: returns a 405 status code, and is hosted on an HTTP/2 site) Change-Id: I19d5d45f5695ae51cf474845182a13f71e9fbb4b Reviewed-on: https://chromium-review.googlesource.com/c/1452789 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#628953}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .