commit | a61bc12b11e325035ec4f2aca54eda34a12abcd6 | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Sat Aug 11 07:49:11 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Aug 11 07:49:11 2018 |
tree | 6521acd5d6fe1f0f463dab6970b85dbb80414fc8 | |
parent | af6cc15556c9d6e46c4c42901398da2916259c18 [diff] |
Revert "[RootScroller] Allow main document horizontal overflow" This reverts commit ace3f1f79bf62fe4f30ae014d8d19caecc94e997. Reason for revert: Checking to see if this caused flaky scrolling failures on Mac 10.13 ( https://bugs.chromium.org/p/chromium/issues/detail?id=873435 ) Original change's description: > [RootScroller] Allow main document horizontal overflow > > When implicitly promoting an element to be the root scroller, we first > check if the main document has any overflow. If it does, we err on the > side of not promoting since it is likely the main document's content is > important and meant to be scrollable. > > This heuristic turns out to be too restrictive. For example, this makes > it hard to build a root scrolling carousel. This CL loosens the > restriction to allow horizontal overflow. > > Bug: 838683 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a > Reviewed-on: https://chromium-review.googlesource.com/1165859 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581408} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 838683 Change-Id: I14e6a0158bb8b06f2344c3b30b38b86c6eabd583 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1172004 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582439}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .