commit d8e4ec69eeabbb26602c5366b1999d1c9877f4ba
author Andres Calderon Jaramillo <andrescj@chromium.org> Fri Dec 16 00:35:49 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 16 00:35:49 2022
tree 285622d93f2e67fe2dd6d4321cba9280ee276b52
parent 2265678d232f89eb0993db75691b014221aaddfb

media: Address some leftover comments from CL:3942434.

This CL addresses leftover work from [1]. Specifically:

- In v4l2_video_decoder_delegate_av1.cc::SetupFrameParams(), the block
  that fills out v4l2_frame_params.order_hints needs to be guarded by
  !libgav1::IsIntraFrame(frame_header->frame_type) instead of
  frame_header.frame_type != libgav1::kFrameKey. The reasons are that a)
  the OrderHints variable in the spec is only filled out for non-intra
  frames (not just for non-key frames); and b) if the frame is
  intra-only or key, frame_header.reference_frame_index may be
  uninitialized [2] so it's unsafe to use it.

- The static_assert that checks the size of the
  v4l2_frame_params.order_hints array is moved closer to the loop and is
  made to compare against libgav1::kNumInterReferenceFrameTypes + 1
  instead of libgav1::kNumReferenceFrameTypes to make it clearer that
  the static_assert is there to document/check that the indices accessed
  by the subsequent loop are safe to access (the loop uses
  libgav1::kNumInterReferenceFrameTypes).

We also make corresponding changes in the standalone
v4l2_stateless_decoder.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3942434/comment/70e35d4c_e7698200/
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/libgav1/src/src/utils/types.h;l=497-499;drc=c55bc9dd7f26ec3b1de0673caa1510bfa3094b3f

Bug: b:248602457
Test: tast run ${IP} video.*av1* on a cherry device
Change-Id: I41b56576f2dfe2c9e7dcf0affa9ae2dc43e544e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112326
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Steve Cho <stevecho@chromium.org>
Reviewed-by: Steve Cho <stevecho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084090}